Patch Set 2: (2 comments)
https://gerrit.osmocom.org/#/c/2884/2/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 351: msisdn = self.resources_pool.next_msisdn(self) This change was needed, otherwise I get an error with something like "suite has not origin element" https://gerrit.osmocom.org/#/c/2884/2/suites/aoip_smpp/esme_ms_sms.py File suites/aoip_smpp/esme_ms_sms.py: Line 47: # FIXME: This test is not failing with error but succeeds, need to check why: (forward vs store policy?) This can be checked/improved later on when extending with more tests. I leave it here as a remembering of tests which can be added later and a show case of the API. -- To view, visit https://gerrit.osmocom.org/2884 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ca3cb009d6d646a449ca99b0200da12085c0da Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
