Patch Set 4: Code-Review+2 (3 comments)
https://gerrit.osmocom.org/#/c/2884/3/src/osmo_gsm_tester/osmo_msc.py File src/osmo_gsm_tester/osmo_msc.py: Line 25: class OsmoMsc(log.Origin): > Ok, I can change that. Is there some specific syntax in python for that? Or yep https://gerrit.osmocom.org/#/c/2884/3/src/osmo_gsm_tester/sms.py File src/osmo_gsm_tester/sms.py: Line 24: def __init__(self, src_msisdn=None, dst_msisdn=None, *tokens): > It looks clearer to me, as in any packet you usually use src + dst terminol Well, ok then, in the sms.db we're using src_addr and dst_addr. Technically an unrelated cosmetic change but it's only changing the function's arg names. https://gerrit.osmocom.org/#/c/2884/3/suites/aoip_smpp/esme_connect_policy_closed.py File suites/aoip_smpp/esme_connect_policy_closed.py: Line 39: esme_no_pwd.disconnect() > it's not like adding a lot of code and this way we assert it won't be an is I don't know, looks like bloat to me. (btw, "paranoid") -- To view, visit https://gerrit.osmocom.org/2884 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ca3cb009d6d646a449ca99b0200da12085c0da Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
