Patch Set 3: > Holger, Neels:Any input on this? For me it's really hard. I > personally believe it makes code less readable, but Max and Pau > claim it is helpful for them...
Doesn't the Linux kernel have macros? The current macro seems to limit us to signed int and not 64bit numbers? (1u << vs. 1 << ). My personal opinion.. not a big gain... but I see how bit set/bit clear can make it easier for some. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: No
