Patch Set 2: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/3103/2//COMMIT_MSG Commit Message: Line 11: in osmo_ss7_vty_init_asp() would be good to name a reason why it should: we understand _sg to mean signalling gateway, but we also want to use the address book in application server processes like BSC and MSC. https://gerrit.osmocom.org/#/c/3103/2/src/osmo_ss7_vty.c File src/osmo_ss7_vty.c: Line 1672: vty_init_shared(); now the _sg does not have an address book anymore? That can't be right. -- To view, visit https://gerrit.osmocom.org/3103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib49ab623055e9ada7f95e0163ba7e33c5f6f99cb Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
