Patch Set 1: (4 comments)
https://gerrit.osmocom.org/#/c/3187/1/include/osmocom/ranap/iu_client.h File include/osmocom/ranap/iu_client.h: Line 43: * ranap_ue_conn_ctx should no longer be used, for whatever reason. */ same here. I'll drop the FIXME because there is no need. Whichever user wants to handle the two events in the same way will just combine switch cases. Line 54: /* TODO "gprs_" in generic CS+PS domain ^ */ more appropriate would be struct osmo_routing_area_id, or could replace with expanded mcc, mnc, lac, rac. https://gerrit.osmocom.org/#/c/3187/1/src/iu_client_vty.c File src/iu_client_vty.c: Line 35: "logging asn1-debug (1|0)", > this is a view/enable node command, i.e. not configuration. Any "logging" I think I added these commands back in the days upon you requesting VTY commands for it. At that time I wasn't much aware of separate logging targets. The asn_debug is a global variable causing printf to stderr from libasn1c/include/asn1c/asn_internal.h:56 ASN_DEBUG() macro. asn1_xer_print is put in generated asn1 code from asn1tostruct.py, hence present in our rua and ranap generated code. Same there, it prints only to stderr so far. If we want to make this generically configurable to separate logging targets, I guess we would have to add a logging category and use libosmocore's LOGP() in libasn1c as well as asn1tostruct.py. In that case we would drop these entirely. So might as well drop them now and come back to the logging category later? Line 80: DEFUN(cfg_iu_local_addr_pc, cfg_iu_local_addr_pc_cmd, > this should be integrated with the SCCP address book, so that a given Iu us you introduced this in the port-to-new-sigtran commit; the address book came later I guess. Should be fine to use the address book -- to clarify, as in the other AoIP discussion on openbsc@: do we also have to supply an ss7 instance id to lookup the address book entry at? By now I guess it would be useful to have a global namespace for address book entries, so that address names belong to a specific ss7 instance, but are guaranteed to be unique; then the name can imply which instance it belongs to. -- To view, visit https://gerrit.osmocom.org/3187 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a3f7ad15be03fb94689b4af6ccfa828c25f45c0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
