Patch Set 1: (2 comments)
some more. I'll go about these issues and come back once it has been tested to work with the new osmo-msc.git and osmo-sgsn.git. https://gerrit.osmocom.org/#/c/3187/1/include/osmocom/ranap/iu_client.h File include/osmocom/ranap/iu_client.h: Line 26: /* TODO: It's not needed to store the full SCCP address for each > it would make sense to clean this up now, before we will first make this pa I took a brief look and the causality is as follows: currently we actually use the public ranap_ue_conn_ctx to pass the sccp_addr up from sccp_sap_up() to the point where we associate it with an RNC. - sccp_sap_up() - OSMO_SCU_PRIM_N_CONNECT: we already now allocate a new ranap_ue_conn_ctx and set sccp_addr = prim->u.connect.calling_addr. - we pass this up the RANAP stack, which decodes the IEs. - finally ranap_handle_co_initial_ue() parses ies->globalRNC_ID - Only now do we find-or-create a struct iu_rnc entry in the global list and set iu_rnc->sccp_addr = ue_conn_ctx->sccp_addr. I believe we should instead use a private struct as data pointer to pass it up the RANAP stack and only actually allocate a public ranap_ue_conn_ctx when the RNC_ID has been parsed successfully. (This would also ensure that we create a UE context only when we were able to parse/handle all of the RANAP. It looks like we fail to clean up the ue_conn_ctx on error at the moment.) Line 32: struct gprs_ra_id ra_id; (and here again I guess rather struct osmo_routing_area_id.) -- To view, visit https://gerrit.osmocom.org/3187 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a3f7ad15be03fb94689b4af6ccfa828c25f45c0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
