Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3354/1/src/sccp_user.c File src/sccp_user.c: Line 335: asp->cfg.local.host = talloc_strdup(asp, local_ip); make sure it is set to NULL otherwise, because the code path above seems to not guarantee that *asp is zeroed out. e.g. ...host = local_ip? talloc_strdup(..) : NULL; same below. (BTW, is one aspect why I didn't like the re-entrant nature of this code, reusing found things instead of making sure this is the first one creating things) -- To view, visit https://gerrit.osmocom.org/3354 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
