Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3354
to look at the new patch set (#2).
sccp: fix possible nullpointer deref
check input parameters local_ip and remote_ip of the function
osmo_sccp_simple_client_on_ss7_id() before using them with
talloc_strdup()
Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905
---
M src/sccp_user.c
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/54/3354/2
diff --git a/src/sccp_user.c b/src/sccp_user.c
index c9443a2..1c818f0 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -331,8 +331,15 @@
goto out_rt;
asp_created = true;
- asp->cfg.local.host = talloc_strdup(asp, local_ip);
- asp->cfg.remote.host = talloc_strdup(asp, remote_ip);
+ if (local_ip)
+ asp->cfg.local.host = talloc_strdup(asp, local_ip);
+ else
+ asp->cfg.local.host = NULL;
+
+ if (remote_ip)
+ asp->cfg.remote.host = talloc_strdup(asp, remote_ip);
+ else
+ asp->cfg.remote.host = NULL;
osmo_ss7_as_add_asp(as, asp->cfg.name);
}
--
To view, visit https://gerrit.osmocom.org/3354
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
