Patch Set 1:

I think particularly if all functions are 'static' and within one file, any 
reasonably optimizing compiler should remove unused function arguments, so this 
is a bit of a pseudo-discussion here.

We do have several places in the code where we pass along some objects either 
to make function signatures similar with other functions, or if we're not sure 
if we will need it at a not-too-distant point (if we take a short-cut by not 
checking some things we should check, e.g.).

Summary: I would simply mark the function as static (as in this patch) but not 
remove unused arguments.  But then, honestly, I don't care.  We can also simply 
leave it like it is.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Holger Freyther <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <>
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-Reviewer: Pablo Neira Ayuso <>
Gerrit-HasComments: No

Reply via email to