Patch Set 1:
I think particularly if all functions are 'static' and within one file, any
reasonably optimizing compiler should remove unused function arguments, so this
is a bit of a pseudo-discussion here.
We do have several places in the code where we pass along some objects either
to make function signatures similar with other functions, or if we're not sure
if we will need it at a not-too-distant point (if we take a short-cut by not
checking some things we should check, e.g.).
Summary: I would simply mark the function as static (as in this patch) but not
remove unused arguments. But then, honestly, I don't care. We can also simply
leave it like it is.
To view, visit https://gerrit.osmocom.org/3422
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org>