Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3473 to look at the new patch set (#2). add esm_class definitions Add special message attributes definitions that are associated with the short message. Thus, we can get rid of magic numbers in our codebase. Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 --- M src/smpp34.h 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/73/3473/2 diff --git a/src/smpp34.h b/src/smpp34.h index 5fb6395..9d51a4a 100644 --- a/src/smpp34.h +++ b/src/smpp34.h @@ -204,4 +204,12 @@ #define TLVID_its_reply_type 0x1380 /* CDMA */ #define TLVID_its_session_info 0x1383 /* CDMA */ +/* As defined by SMPP 3.4, Sect. 5.2.12 Parameter Definition esm_class. */ +#define SMPP34_DATAGRAM_MODE 0x01 +#define SMPP34_MSG_MODE_MASK 0x03 +#define SMPP34_DELIVERY_RECEIPT 0x04 +#define SMPP34_DELIVERY_ACK 0x08 +#define SMPP34_UDHI_IND 0x40 +#define SMPP34_REPLY_PATH 0x80 + #endif -- To view, visit https://gerrit.osmocom.org/3473 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 Gerrit-PatchSet: 2 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org>