Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3524/1/openbsc/src/libmsc/smpp_openbsc.c File openbsc/src/libmsc/smpp_openbsc.c: Line 100: unsigned int sms_msg_len = 0; /* initialization not needed but compilers cry with -Wmaybe-uninitialized */ This comment on the right is too much... We have 'git annotate' these days... BTW, in the kernel, this is preferred: const uint8_t *sms_msg = NULL; unsigned int sms_msg_len = 0; struct gsm_subscriber *dest; uint16_t msg_ref = 0; struct gsm_sms *sms; struct tlv_t *t; ie. variables are declared from longer line to smaller line, it makes things more readable... Just a couple of nitpicks... Nothing very much relevant here. -- To view, visit https://gerrit.osmocom.org/3524 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0901ddadb5f72e1585cb1797ac22c8ab95e83146 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-HasComments: Yes
