Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/3524/2/openbsc/src/libmsc/smpp_openbsc.c File openbsc/src/libmsc/smpp_openbsc.c: Line 120: } > maybe initialize this before the msg_payload call? I tried doing this: case TLVID_message_payload: sms_msg_len = 0; if (smpp34_submit_tlv_msg_payload(t, submit, &sms_msg, But compilation error is still triggered. It's also clearer for me to just initialize it at the start of the function. -- To view, visit https://gerrit.osmocom.org/3524 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0901ddadb5f72e1585cb1797ac22c8ab95e83146 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
