Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/db.c File openbsc/src/libmsc/db.c: Line 1708: "SELECT datetime(SMS.created,'localtime') as created, SMS.* " > Probably this is breaking openbsc/tests/db/db_test ? Funny enough, not on my local box. But then, if one does a SELECT x as created, * from table, and table has a field called created, the result set contain two 'created's. No idea what libdbi does with this. The error is from dbi_result_get_datetime(result, "created"); DBI: -7: The requested variable type does not match what libdbi thinks it should be There is a FIXME in sms_from_result() /* FIXME: those should all be get_uchar, but sqlite3 is braindead */ followed by dbi_result_get_ulonglong() for all fields except dest_addr, src_addr and user data. I might ask Holger if he wrote that FIXME -- To view, visit https://gerrit.osmocom.org/3540 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-HasComments: Yes
