Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/gsm_04_11.c File openbsc/src/libmsc/gsm_04_11.c: Line 313: gsm340_gen_scts(smsp, sms->created); > Not sure what your question is? :-) It's not clear from the spec what the SCTS should be in this case? The time we are sending the report, or the time the report relates to? The spec is pretty clear about the Discharge time: "The TP-Discharge-Time field indicates the time at which a previously submitted SMS-SUBMIT was successfully delivered to or attempted to deliver to the recipient SME or disposed of by the SC." -- To view, visit https://gerrit.osmocom.org/3540 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-HasComments: Yes
