Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/3570/1/openbsc/include/openbsc/gsm_data_shared.h File openbsc/include/openbsc/gsm_data_shared.h: Line 132: #define MAX_A5_KEY_LEN (128/8) I think it's better to put this next to actual a5 implementation in libosmocore. Line 235: uint8_t alg_id; Is this enum osmo_auth_algo or smth else? -- To view, visit https://gerrit.osmocom.org/3570 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15d60441c6c6f053486c0482258a8759bdd92df1 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
