Patch Set 1: Code-Review+2 I agree with max' comments but I think this is a simple "revert" of an existing commit. So the issues should be resolved separately, and not in the same commit as the revert, right?
-- To view, visit https://gerrit.osmocom.org/3570 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15d60441c6c6f053486c0482258a8759bdd92df1 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: No
