Patch Set 2: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/3132/2/contrib/jenkins-arm.sh File contrib/jenkins-arm.sh: PS2, Line 6: - you are introducing cosmetic changes (all arguments on same line vs. separate lines) with a clean-up, making it much harder to read and thus validate that no unintentional changes are introduced. -- To view, visit https://gerrit.osmocom.org/3132 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e500e132f5c8e8133d35548cb7b4e4552331d0 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: blobb <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
