Patch Set 1: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-common.sh File contrib/jenkins-build-common.sh: Line 154: if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then what are those underscores in there used for? I guess they can be removed. Or otherwise the first and last spaces are removed? https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-osmo-nitb.sh File contrib/jenkins-build-osmo-nitb.sh: Line 15: create_bin_tgz osmo-nitb If merging this commit before already adding the build job with osmo-sgsn, please keep it in here too. Otherwise if merging all support at the same time or during same day, it's fine to directly remove it. https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-osmo-pcu-sysmo.sh File contrib/jenkins-build-osmo-pcu-sysmo.sh: Line 19: create_bin_tgz osmo-pcu-sysmo I think that's the wrong binary: # du -la osmo-pcu-sysmo/ | grep bin/osmo-pcu 2088 osmo-pcu-sysmo/bin/osmo-pcu -- To view, visit https://gerrit.osmocom.org/3818 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1a00b2149453fedf9ece0460dd4d6e83f774d45 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
