Patch Set 2: (3 comments)
https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-common.sh File contrib/jenkins-build-common.sh: Line 154: if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then > what are those underscores in there used for? I guess they can be removed. yes, it's to make sure each binary name is surrounded by two spaces ... I thought about regex '\<$f\>' but that might also hit at '-', so I decided to make space the delimiter and guarantee it on both ends. https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-osmo-nitb.sh File contrib/jenkins-build-osmo-nitb.sh: Line 15: create_bin_tgz osmo-nitb > If merging this commit before already adding the build job with osmo-sgsn, osmo-sgsn is already added and going to be available; just need to adjust the patch that is in the queue to pick the osmo-sgsn binary from the osmo-sgsn installation https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-osmo-pcu-sysmo.sh File contrib/jenkins-build-osmo-pcu-sysmo.sh: Line 19: create_bin_tgz osmo-pcu > I think that's the wrong binary: ah ok -- To view, visit https://gerrit.osmocom.org/3818 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1a00b2149453fedf9ece0460dd4d6e83f774d45 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
