Patch Set 1: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/3815/1/src/osmo_gsm_tester/osmo_bsc.py File src/osmo_gsm_tester/osmo_bsc.py: Line 89: encryption_vty = util.encryption2osmovty(values['bsc']['net']['encryption']) hmm, I didn't think of this, now we need to translate the value kept in the config. This is moving part of rendering the model into the realm of composing the object, so, strictly speaking, this is breaking the DOM separation. It would be cleaner to still just overlay the config here, and do the conversion in the template rendering itself. I still have to make up my mind whether we should bother, and try out how it would look in the template. Will this sort of thing re-appear for other values and we need a whole layer for conversion? So far we only have 1:1 vty compatibility for all values and names, right? We have constants for the band ('GSM-1800'), but these are translated to an ARFCN and never end up in the VTY as such. Sorry for the diversion here. We can also merge this and I can come back to it later... Thoughts? https://gerrit.osmocom.org/#/c/3815/1/src/osmo_gsm_tester/util.py File src/osmo_gsm_tester/util.py: Line 319: return 'a5 ' + val[3:] well, what if I feed 'a5_potato' :) -- To view, visit https://gerrit.osmocom.org/3815 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5265cc9990dd5e99dba1f6262b3a8c597a3e958d Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
