Patch Set 2: Code-Review+1 (1 comment)
(decide and +2 for yourself please, if you wish) https://gerrit.osmocom.org/#/c/3815/2/selftest/template_test/osmo-nitb.cfg.tmpl File selftest/template_test/osmo-nitb.cfg.tmpl: Line 27 If we keep the 'a5' in here, we can leave 'encryption' as an integer and bypass the discussion about underscores, translation to vty format. I don't really have a strong opinion, you can merge this as far as I'm concerned. (Otherwise we need some adjustment in the other encryption patch) -- To view, visit https://gerrit.osmocom.org/3815 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5265cc9990dd5e99dba1f6262b3a8c597a3e958d Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
