Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3830/1/src/osmux.c File src/osmux.c: Line 941: /* This _snprintf() variant always nul-terminates the buffer. */ > I still don't get why you say at least some variants of snprintf don't cont Because I got confused. I remember your original patch is trying to ensure that we leave room for the nul-termination. Anyway, bottom line is: I don't we need this patch at all. Given that snprintf() output is always nul-terminated, the last snprintf() call already guarantees that we deliver a nul-terminated buffer. So all this logic this patch adds is entirely superfluous. I'm going to abbandon this patch. -- To view, visit https://gerrit.osmocom.org/3830 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
