Patch Set 2: (1 comment)
Sorry for keeping you busy with this, I'm just pointing out possibilities of crash I see in the code though. If you don't want to invest more time on these then just write the requirements for each parameter in documentation of the function, and it can be fixed later to remove those extra requirements. https://gerrit.osmocom.org/#/c/3830/2/src/osmux.c File src/osmux.c: Line 905: buf[0] = '\0'; Invalid access in case it is called with size==0. -- To view, visit https://gerrit.osmocom.org/3830 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
