Patch Set 3: Code-Review+1 (2 comments)
You don't mention "duplicate" avoidance. I don't think we should derive it from the prompt... https://gerrit.osmocom.org/#/c/3979/3/src/vty/command.c File src/vty/command.c: Line 158: if (!*node->name) use node->name[0]? But why derive it from the prompt? It seems like an interim solution only? Line 612: same_name_count = 1; Why start with 1? For the first node it has not used before? -- To view, visit https://gerrit.osmocom.org/3979 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa555570268b231c5e01727c661da92fad265de Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
