Patch Set 5: Code-Review+1 I like the idea, but why not simply add the "name" attribute in addtion to the existing "node-id" attribute? This way the old 'vty-additions.xml' would still work, while we could write new ones referring to the names? In any case, if that adds extra work for some reason I'm missing here, nevermind. We can merge it and convert the vty-additions.xml very easily - and as you have stated, this doesn't have to happen at the same time.
-- To view, visit https://gerrit.osmocom.org/3979 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa555570268b231c5e01727c661da92fad265de Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
