laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23577 )
Change subject: Add more documentation to the classes/methods ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py@45 PS2, Line 45: parent:'CardDF'=None > The linters won't be happy about this, you need […] Thanks a lot. However: File "/space/home/laforge/projects/git/pysim/pySim/filesystem.py", line 47, in CardFile parent:Optional('CardDF')=None): File "/usr/lib/python3.9/typing.py", line 335, in __call__ raise TypeError(f"Cannot instantiate {self!r}") TypeError: Cannot instantiate typing.Optional -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6ac88e0662cf3c56ae32d86d50b18a8b4150571a Gerrit-Change-Number: 23577 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: herlesupreeth <[email protected]> Gerrit-Reviewer: merlinchlosta <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Fri, 02 Apr 2021 14:57:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
