laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23577 )
Change subject: Add more documentation to the classes/methods ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/commands.py@141 PS2, Line 141: length:int=None > Python is weird: […] I decided to keep that as-is. https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py@45 PS2, Line 45: parent:'CardDF'=None > Ah, sorry for confusion. I gave you a wrong example. It should be: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6ac88e0662cf3c56ae32d86d50b18a8b4150571a Gerrit-Change-Number: 23577 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: herlesupreeth <[email protected]> Gerrit-Reviewer: merlinchlosta <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Fri, 02 Apr 2021 19:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
