pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 )
Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID ...................................................................... Patch Set 5: (2 comments) Marking as WIP since I may need to rework the patch again. I also need to update in a follow-up patch the last_used_plmn_id field, when receiving a Handover Request (SRVCC use case). The problem is that IMSI IE in Handover Request is optional, which means the conn may still have no subscriber associated at that time, and hence I'm unable to store the last_used_plmn_id there. I think I'll need to move the last_used_plmn_id from "struct bsc_subscr" to "struct gsm_subscriber_connection". Does that make sense to any of you? https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/include/osmocom/bsc/bsc_subscriber.h File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/include/osmocom/bsc/bsc_subscriber.h@48 PS5, Line 48: struct bsc_subscr *bsub > also const Ack https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/src/osmo-bsc/bsc_subscr_conn_fsm.c@885 PS5, Line 885: TLVP_VAL > I guess you meant TLVP_PRES or even TLVP_PRES_LEN here? TLVP_PRES, but anyway it's basically the same. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5d290ac55eca5adde1c33396422f4c10b83c03d5 Gerrit-Change-Number: 23734 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Fri, 16 Apr 2021 15:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
