dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 )
Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID ...................................................................... Patch Set 7: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/23734/7/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23734/7/src/osmo-bsc/lchan_fsm.c@1610 PS7, Line 1610: } wonder what happens with existing values in lchan->release.last_eutran_plmn_valid and lchan->release.last_eutran_plmn when last_eutran_plmn is NULL. Just wanted to make you aware of this, I do not have enough background of this so I cant say if this can be a problem or not. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5d290ac55eca5adde1c33396422f4c10b83c03d5 Gerrit-Change-Number: 23734 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 11:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
