laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/23187 )

Change subject: gprs_ns2: implement local update weight procedure
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c@1641
PS5, Line 1641:         case GPRS_SNS_ST_LOCAL_PROCEDURE:
> Not sure how wise it is to mix enums in here that could theoretically clash 
> with the other timer val […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454
Gerrit-Change-Number: 23187
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Sat, 08 May 2021 09:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to