osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969 )
Change subject: msc: Verify CommonID contains LastUsedEutranPLMNId when in CSFB ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/2/library/BSSMAP_Templates.ttcn File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/2/library/BSSMAP_Templates.ttcn@1184 PS2, Line 1184: } else if (not istemplatekind(mcc_mnc, "omit")) { Why not switch this and the else and avoid "not istemplatekind"? } else if (istemplatekind(mcc_mnc, "omit")) { That's slightly more readable IMHO. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I161529fd9c8cacb7d17ea18660998df06bb0b575 Gerrit-Change-Number: 23969 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 11 May 2021 12:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
