Patch Set 1: I think we decided quote some time ago not to introduce such helper functions anymore - and/or if at all, make them inline wrappers around the access to the respective value string array. So now there's the conflict in whether we align with current best practises or with the style that's used in the file so far.
Also, this is yet another change that will break compilation with older libosmocore version. For I believe *very* questionable gain. So we spend time on writing this code, changing all the existing users, reviewing it, merging it and then it will cause more build failures. Interested in other opinions, but my gut feeling is to not merge this. -- To view, visit https://gerrit.osmocom.org/4355 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieace734aaff3f07606113feddde65b75202d96d6 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
