Patch Set 1: > What change will break anything? Aligning the rest of the file to > static inline functions? Then let's not?
This change will break building against older libosmocore versions without a good reason to do so. The new abis_nm_admin_name() function (whether inline or real function) will not be present in older libraries. We have to stop breaking API compatibility all the time for no good reason. I don't think this is one. -- To view, visit https://gerrit.osmocom.org/4355 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieace734aaff3f07606113feddde65b75202d96d6 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
