alealcon has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24283 )

Change subject: srs-enb: adds environment variables to the resources schema.
......................................................................


Patch Set 1:

> Patch Set 1:
>
> how/why is this used? I only see the var being added there.

this is a preparation for the next commit, which includes the malloc 
interceptor but I as see more than one functionality I segregate into 2 
different commits (one for the malloc interceptor and one for passing 
enviroment variables to the srs_enb).
What it's missing here is to add the variables to the env dictionary before 
launching the enb (it's only added for the malloc interceptor case).

Does that sound good to you?


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24283
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I3e5c0ca66ae88d5f3a3ed04c620f386afe1afac9
Gerrit-Change-Number: 24283
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 21 May 2021 08:15:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to