fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 )
Change subject: add bsc/BSC_Tests_VAMOS.ttcn ...................................................................... Patch Set 1: Code-Review-2 (2 comments) This change introduces a lot of duplicated records/functions. You can avoid this using the 'friend'-imports, see ETSI ES 201 873-1, section 8.2.4 "Definition of friend modules". We already use this feature a lot in BTS_Tests[SMSCB,OML,perf].ttcn. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn File bsc/BSC_Tests_VAMOS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn@94 PS1, Line 94: SystemInformationConfig This record can be imported from BSC_Tests (check 'friend' keyword), no need to duplicate it here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn@109 PS1, Line 109: SystemInformationConfig_omit Same here and down below. Maintaining copies of the same records/functions is going to be painful, so let's avoid it as much as possible. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c504099163a30ea102cbd26d3615ca2e5ce1e64 Gerrit-Change-Number: 24411 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 May 2021 14:12:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
