fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 )
Change subject: add bsc/BSC_Tests_VAMOS.ttcn ...................................................................... Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/4/bsc/BSC_Tests_VAMOS.ttcn File bsc/BSC_Tests_VAMOS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/4/bsc/BSC_Tests_VAMOS.ttcn@116 PS4, Line 116: var RslChannelNr chan_nr := rsl.ies[0].body.chan_nr; With the recent RSL chan_nr changes, we should probably also do: if (not match(chan_nr, t_RslChanNr_Osmo_VAMOS_Bm(1)) { ... } https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/4/bsc/BSC_Tests_VAMOS.ttcn@174 PS4, Line 174: RSL.receive(tr_RSL_MODE_MODIFY_REQ(g_chan_nr, ?)) -> value rsl; Would also be good to match chan_nr against t_RslChanNr_Osmo_VAMOS_Bm. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c504099163a30ea102cbd26d3615ca2e5ce1e64 Gerrit-Change-Number: 24411 Gerrit-PatchSet: 5 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 27 May 2021 16:13:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
