daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24685 )
Change subject: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED ...................................................................... Patch Set 2: > Patch Set 1: > > > Patch Set 1: > > > > I'm not sure/convinced that 'unconfigured' is a wrong name. Why would > > "unconfigured" only happen at start-up? What event is causing it to become > > unconfigured later on again, and why is the name wrong? Is it still in some > > way "configured" while in that state? > > Original the unconfigured was just the initial state. Later a vty command for > testing was introduced. And now the frame relay is forcing all NSVC into the > unconfigured state when the DLCI become unavailable. A bit more bike shedding, but to me "disabled" sounds like some active intervention is needed before the NSVC can be used again. "Unconfigured" as a state name sounds fine to me, or maybe something like "initial", "inactive" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f46ce5e27d7556d5e17bc236f1765d42aecbe0c Gerrit-Change-Number: 24685 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 06 Jul 2021 09:42:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
