laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24685 )

Change subject: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED
......................................................................


Patch Set 2: Code-Review-1

to be honest, I don't see how any of the proposed wordings are better or have 
less optoins for misundersanding as the current one.  "changing sideways" 
rather than forward, IMHO.  I'm sorry, I wish I could come to a different 
conclusion.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ce5e27d7556d5e17bc236f1765d42aecbe0c
Gerrit-Change-Number: 24685
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 31 Aug 2021 09:24:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to