Patch Set 2: IUUC it doesn't only fix the warning, but was also an actual error. vector_slot(V,I) should amount to a void*, right? In the surrounding code, it is used as char*, and the vline vector, IIUC, is a list of string tokens, each terminated by '\0'. So this should actually be a functional change, checking whether the current token is just "\0", in contrast to before, where it checked, in effect, whether the token is NULL. Can we pinpoint a functional change from this patch / could there be fallout?
-- To view, visit https://gerrit.osmocom.org/4389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaba9e3450d68c51e16a7bda2fc0fc370992ca866 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
