Patch Set 1: > As we already screwed up with the first attempt to merge a fix, I > would rather not want to touch this code again unless we have a > test case.
Do you imply you don't want to merge this patch unless there's a test case? This new patch is not changing logic, as '\0' = 0x0 = NULL, so we should be on the safe side now to at least not add new breakage. -- To view, visit https://gerrit.osmocom.org/4672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9e02bbf89e0a94e1766b1efd236538712415c8a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
