lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/22766 )

Change subject: Make UTRAN encryption algorithms configurable
......................................................................


Patch Set 3:

(1 comment)

Without any configuration changes I get
> "encryption uea 1 2"

The location update works with my s8 tr069 node. The s8 take uia1 as encryption.

When changing it to
> "encryption uea 2"

The s8 choose no encryption.

I also saw a SecurityCommand failing, when the msc set encryption+integrity, 
but a little bit later when the LU/CS was still ongoing, the sgsn sent a 
SecurityCommand with only integrity, the security command failed.

https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c
File src/libmsc/ran_msg_iu.c:

https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c@375
PS3, Line 375:  return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, 
cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL,
You mismatched the arguments. The keystatus needs to be in fron of 0x06.
```
        return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, 
cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL, RANAP_KeyStatus_new, 
0x06, cm->utran.uea_encryption_mask);
```



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd
Gerrit-Change-Number: 22766
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Assignee: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 13 Oct 2021 19:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to