pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 )
Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c@1296 PS4, Line 1296: is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, it may make sense to have an msc_a_encryption_enabled(msc_a) function, since you do this complex testing in lots of places. This way all the logic is only present in one place and avoids future possible breakage. https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@371 PS4, Line 371: for (i = 0; i < 8; i++) { So in the command above we only support UEA0/1/2, but here we go up to 8. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Assignee: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 19 Oct 2021 16:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
