Patch Set 14: Code-Review-1 (5 comments)
(introducing new comment markings -- '-1:' are the blockers, '?:' aren't important...) https://gerrit.osmocom.org/#/c/4006/14/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: Line 147: static void codecs_update(void *ctx, struct sdp_rtp_map *codecs, int used, ?: const struct ... codecs Line 197: * \param[out] conn associated rtp connection. -1: oh, conn is also an output param? if yes, explain what is returned in conn Line 335: * \returns 0 on success, -1 on failure. */ -1: this returns doc is not accurate, you're returning the len. Why though? the msgb is good in keeping its size. Line 350: ?: add /* FIXME: constify endp and conn args in get_net_donwlink_format_cb() */ and best follow up with a separate patch now. Line 366: len += rc; ?: I guess we can skip counting the len and just return 0 below..... -- To view, visit https://gerrit.osmocom.org/4006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324 Gerrit-PatchSet: 14 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
