Patch Set 12: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/4006/12/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: Line 260: &port, &codecs[0].payload_type, I see tons of whitespace changes in this path that don't really seem neccessary. Lke this re-indenting. Makes it hard to see what was actually changed functionally in the code; also will break any other patches that people may have possibly have made due to whitespace patch hunk breakage. If at all, the whitespace changes should be a separate "cosmetics only" patch. -- To view, visit https://gerrit.osmocom.org/4006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324 Gerrit-PatchSet: 12 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
