fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 30: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/30/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/30/src/libosmo-mgcp/mgcp_vty.c@1589 PS30, Line 1589: DEFUN(cfg_mgcp_num_threads_for_virttrunk, cfg_mgcp_num_threads_for_virttrunk_cmd, "number threads <1-65534>", For the sake of consistency, please reformat this as it's done above: DEFUN(cfg_mgcp_num_threads_for_virttrunk, cfg_mgcp_num_threads_for_virttrunk_cmd, "number threads <1-65534>", ... Also, you have three vectors here: "number", "threads", and "<1-65534>", so it's required to provide documentation for all of them. But I would rather go for a better naming like "num-threads" or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 30 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 09 Nov 2021 19:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
