pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )

Change subject: rework the counters and stats so they work with the threaded mgw
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c
File src/libosmo-mgcp/mgcp_threads.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c@498
PS5, Line 498:  usleep(1000 * 100);
Let's rather have some volatile integer per thread or alike to check this, with 
a static bool done = true when it holds true. Maybe simply a global static 
counter which is incremented every time a thread is ready.

 You can incorporate that into rate_ctr_timer_cb and keep checking every second 
or even less in this case.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0
Gerrit-Change-Number: 26190
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 10 Nov 2021 13:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to