Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )
Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 6: (5 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h File include/osmocom/mgcp/mgcp_conn.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h@a134 PS5, Line 134: /* RTP connection related counters */ > So you are removing the counters from here but still using them immediatelly > afterwards? how is that […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h@27 PS5, Line 27: #include <osmocom/mgcp/mgcp_network.h> > I don't see mgcp/mgcp_ratectr. […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h File include/osmocom/mgcp/mgcp_ratectr.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h@15 PS5, Line 15: }; > yo should perhaps move the rate_ctr dscriptions here too? Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c@a129 PS5, Line 129: osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common, > so we lost these counters? No, as the commit message states they get updated once per second in the rate timer cb. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c@498 PS5, Line 498: usleep(1000 * 100); > Let's rather have some volatile integer per thread or alike to check this, > with a static bool done = […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 17 Nov 2021 20:35:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
