laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 )
Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c@a545 PS6, Line 545: return rc; I think it doesn't hurt to do the check_bts already at startup time (and then re-check it again on OML startup)? Or is it illegal to call check_bts() several times? The point is that currently the user got an error message right at BSC start-up if check_bts fails, and I think we shouldn't remove that u nless there is a strict reason. bootstrap_bts can of course be removed here and only called during oml startup. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 11 Nov 2021 08:58:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
