osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 )
Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: (2 comments) looks good besides also doing the check on startup. (I didn't realize that there were already lots of reviews here.) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c@a545 PS6, Line 545: return rc; > Makes sense. +1 https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c@496 PS6, Line 496: LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n", trx->bts->nr); (very long line, break before trx->bts->nr? same below) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Comment-Date: Fri, 12 Nov 2021 14:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
