Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )
Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 12: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h@29 PS9, Line 29: atomic_int_least32_t thread_ready_counter; /* used to check if all child trunk threads are ready for action */ > This is only used by the top trunk right? But this struct is duplicated for > each thread iirc? yes. just like the 22kb e1 struct at the bottom. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c@322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); > No, in order to be initialized it should be: […] I've already fixed this yesterday, but accidentally dropped the changes for this patch again, because this patch existed a second time with a different gerrit id. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c@498 PS9, Line 498: while (trunk->use_threads && trunk->thread_ready_counter != num_threads) > iiuc there's no need to check trunk->us_threads here? or is num_threads 1 > when we run in single thre […] yes, see 20 lines above. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 18 Nov 2021 18:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
